Bug 75166

Summary: Web Inspector: Implement a worker for parsing out JavaScript function data
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Alexander Pavlov (apavlov)
Reported 2011-12-23 00:53:25 PST
This is necessary for implementing the Go to Function dialog
Attachments
Patch (17.63 KB, patch)
2011-12-23 01:42 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (17.05 KB, patch)
2011-12-23 03:50 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (8.69 KB, patch)
2011-12-23 04:36 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (11.54 KB, patch)
2011-12-23 05:40 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-12-23 01:42:15 PST
Created attachment 120443 [details] Patch
Pavel Feldman
Comment 2 2011-12-23 03:12:08 PST
Comment on attachment 120443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68 > + buildScriptOutline(); I think you should combine this worker with the one that formats source. > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140 > + setTimeout(buildScriptOutline, 0); You should not use setTimeout in worker.
Alexander Pavlov (apavlov)
Comment 3 2011-12-23 03:50:05 PST
Created attachment 120454 [details] Patch
Alexander Pavlov (apavlov)
Comment 4 2011-12-23 03:51:20 PST
(In reply to comment #2) > (From update of attachment 120443 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review > > > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68 > > + buildScriptOutline(); > > I think you should combine this worker with the one that formats source. As agreed offline, we shall forcefully terminate the worker if a new source needs to be reparsed, so retaining this as a separate worker. > > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140 > > + setTimeout(buildScriptOutline, 0); > > You should not use setTimeout in worker. Done.
Alexander Pavlov (apavlov)
Comment 5 2011-12-23 04:36:25 PST
Created attachment 120457 [details] Patch
Alexander Pavlov (apavlov)
Comment 6 2011-12-23 05:40:49 PST
Created attachment 120462 [details] Patch
Alexander Pavlov (apavlov)
Comment 7 2011-12-23 07:41:15 PST
Committed r103627: <http://trac.webkit.org/changeset/103627>
Note You need to log in before you can comment on or make changes to this bug.