Bug 74983

Summary: Extract WinCE CMake arguments from build-webkit into separate function
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, paroga, rakuco, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74979    
Bug Blocks: 74985    
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2011-12-20 17:44:24 PST
Towards adding support to only build JavaScriptCore for the WinCE port using script Tools/Script/build-jsc, we need to extract the WinCE CMake argument from build-webkit into a separate function so that we can call this function when passing the CMake arguments to webkitdirs::buildCMakeProjectOrExit() from within Tools/Script/build-{webkit, jsc}.
Attachments
Patch (2.21 KB, patch)
2011-12-20 17:59 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2011-12-21 10:33 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2011-12-20 17:59:42 PST
Created attachment 120129 [details] Patch
Patrick R. Gansterer
Comment 2 2011-12-21 00:55:10 PST
Comment on attachment 120129 [details] Patch what about changing this a "additional cmake arguments" function. Maby some other port need some additonal variables for the port too? otherwise LGTM
Daniel Bates
Comment 3 2011-12-21 10:33:50 PST
Created attachment 120193 [details] Patch Added function webkitdirs::cmakeBasedPortArguments() and moved WinCE-specific CMake arguments into it. Also, use cmakeBasedPortArguments() when constructing the the list of CMake arguments for the EFL port. Currently, cmakeBasedPortArguments() returns the empty list for the EFL port.
Rob Buis
Comment 4 2011-12-21 11:00:53 PST
Comment on attachment 120193 [details] Patch Looks good.
Daniel Bates
Comment 5 2011-12-21 11:09:47 PST
Comment on attachment 120193 [details] Patch Clearing flags on attachment: 120193 Committed r103418: <http://trac.webkit.org/changeset/103418>
Daniel Bates
Comment 6 2011-12-21 11:09:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.