| Summary: | Extract WinCE CMake arguments from build-webkit into separate function | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gyuyoung.kim, leandro, paroga, rakuco, rwlbuis, tonikitoo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 74979 | ||||||||
| Bug Blocks: | 74985 | ||||||||
| Attachments: |
|
||||||||
Created attachment 120129 [details]
Patch
Comment on attachment 120129 [details]
Patch
what about changing this a "additional cmake arguments" function. Maby some other port need some additonal variables for the port too? otherwise LGTM
Created attachment 120193 [details]
Patch
Added function webkitdirs::cmakeBasedPortArguments() and moved WinCE-specific CMake arguments into it. Also, use cmakeBasedPortArguments() when constructing the the list of CMake arguments for the EFL port. Currently, cmakeBasedPortArguments() returns the empty list for the EFL port.
Comment on attachment 120193 [details]
Patch
Looks good.
Comment on attachment 120193 [details] Patch Clearing flags on attachment: 120193 Committed r103418: <http://trac.webkit.org/changeset/103418> All reviewed patches have been landed. Closing bug. |
Towards adding support to only build JavaScriptCore for the WinCE port using script Tools/Script/build-jsc, we need to extract the WinCE CMake argument from build-webkit into a separate function so that we can call this function when passing the CMake arguments to webkitdirs::buildCMakeProjectOrExit() from within Tools/Script/build-{webkit, jsc}.