Bug 74484

Summary: [Blackberry] Remove some duplicate entries in Source/WebCore/PlatformBlackBerry.cmake
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, rakuco, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jacky Jiang
Reported 2011-12-13 23:07:03 PST
Remove some duplicate entries in Source/WebCore/PlatformBlackBerry.cmake
Attachments
Patch (1.91 KB, patch)
2011-12-13 23:22 PST, Jacky Jiang 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2011-12-14 08:59 PST, Jacky Jiang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jacky Jiang
Comment 1 2011-12-13 23:22:22 PST
Created attachment 119164 [details] Patch
WebKit Review Bot
Comment 2 2011-12-13 23:36:17 PST
Comment on attachment 119164 [details] Patch Rejecting attachment 119164 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: iewer', u'Daniel Bates', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/PlatformBlackBerry.cmake Hunk #1 succeeded at 75 with fuzz 1. Hunk #2 FAILED at 172. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/PlatformBlackBerry.cmake.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Daniel Bates', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/10874138
Jacky Jiang
Comment 3 2011-12-14 08:27:25 PST
(In reply to comment #2) > (From update of attachment 119164 [details]) > Rejecting attachment 119164 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/PlatformBlackBerry.cmake.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Daniel Bates', u'--for..." exit_code: 1 > > Full output: http://queues.webkit.org/results/10874138 This failure may be caused by the change of https://bugs.webkit.org/show_bug.cgi?id=74475 hasn't been pushed when picking this patch, I will update it and try again.
Jacky Jiang
Comment 4 2011-12-14 08:59:28 PST
Created attachment 119228 [details] Patch Update the patch based on the latest code and try again.
WebKit Review Bot
Comment 5 2011-12-14 10:47:16 PST
Comment on attachment 119228 [details] Patch Clearing flags on attachment: 119228 Committed r102798: <http://trac.webkit.org/changeset/102798>
WebKit Review Bot
Comment 6 2011-12-14 10:47:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.