Bug 74414

Summary: [Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72943    
Attachments:
Description Flags
Patch
none
Patch
none
Patch hausmann: review+

Caio Marcelo de Oliveira Filho
Reported 2011-12-13 09:00:15 PST
[Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
Attachments
Patch (20.43 KB, patch)
2011-12-13 09:02 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Patch (26.59 KB, patch)
2011-12-13 10:07 PST, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
Patch (26.66 KB, patch)
2011-12-13 10:55 PST, Caio Marcelo de Oliveira Filho 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-12-13 09:02:04 PST
Created attachment 119026 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-12-13 09:06:42 PST
Comment on attachment 119026 [details] Patch r=me, some things could be better as discussed on irc... but bady steps :)
Caio Marcelo de Oliveira Filho
Comment 3 2011-12-13 10:07:10 PST
Created attachment 119031 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 4 2011-12-13 10:25:09 PST
(In reply to comment #2) > (From update of attachment 119026 [details]) > r=me, some things could be better as discussed on irc... but bady steps :) Kenneth, I have changed a bit, and I've moved the event handler into the quickwebpage. This way quickwebpage doesn't need to be aware of quickwebview. I think it is a bit better. Can you look at this new patch? :-)
Caio Marcelo de Oliveira Filho
Comment 5 2011-12-13 10:55:31 PST
Created attachment 119040 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 6 2011-12-14 04:50:32 PST
Committed r102765: <http://trac.webkit.org/changeset/102765>
Note You need to log in before you can comment on or make changes to this bug.