Bug 74357
| Summary: | [chromium] Need expectations for plugins/netscape-plugin-page-cache-works.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | beidson |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 13634 | ||
| Bug Blocks: | |||
Kenneth Russell
http://trac.webkit.org/changeset/102619 introduced layout test plugins/netscape-plugin-page-cache-works.html which needs Chromium expectations.
Suppressing the failure for the moment.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
Suppressed in http://trac.webkit.org/changeset/102630 .
Kenneth Russell
This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.
Brady Eidson
(In reply to comment #2)
> This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.
AFAIK, Chromium has never supported the WebCore page cache... just as an FYI.
I would be surprised to hear if you planned to; Please comment if that's the case...
Kenneth Russell
(In reply to comment #3)
> (In reply to comment #2)
> > This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.
>
> AFAIK, Chromium has never supported the WebCore page cache... just as an FYI.
>
> I would be surprised to hear if you planned to; Please comment if that's the case...
You're right, it looks like Chromium does not use WebCore's page cache by default, though it can be enabled via a command line option.
However, Chromium's LayoutTestController does support the WebKitUsesPageCachePreferenceKey, so it seems that it should also support WebKitPageCacheSupportsPluginsPreferenceKey.
Kenneth Russell
Expanded the suppression in http://trac.webkit.org/changeset/102647 .
For the record, I tried implementing the obvious DumpRenderTree support for the new flag, but the test still fails. It looks like the test page doesn't navigate back properly.
Kenneth Russell
Unfortunately it looks like the test timeout may be causing other tests in the shard to fail. Actually skipped the test in http://trac.webkit.org/changeset/102654 .
Stephen Chenney
Marking test failures as WontFix. Bug is still accessible and recording in TestExpectations.