Bug 74338

Summary: Remove uses of JSFinalObject vptr
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74332    
Bug Blocks: 74331    
Attachments:
Description Flags
Remove uses of JSFinalObject vptr ggaren: review+

Mark Hahnenberg
Reported 2011-12-12 14:30:39 PST
Same as bug 74333, but with JSFinalObject.
Attachments
Remove uses of JSFinalObject vptr (29.64 KB, patch)
2011-12-12 14:51 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-12-12 14:51:11 PST
Created attachment 118861 [details] Remove uses of JSFinalObject vptr No changelog (see bug 74331).
Geoffrey Garen
Comment 2 2011-12-12 15:02:31 PST
Comment on attachment 118861 [details] Remove uses of JSFinalObject vptr View in context: https://bugs.webkit.org/attachment.cgi?id=118861&action=review r=me > Source/JavaScriptCore/heap/MarkStack.cpp:310 > + if (cell->classInfo() == &JSFinalObject::s_info) { I'd create an isJSFinalObject() helper and use that here.
Note You need to log in before you can comment on or make changes to this bug.