Bug 74333

Summary: Remove JSString vptr optimizations
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74332    
Bug Blocks: 74331    
Attachments:
Description Flags
Remove JSString vptr optimizations ggaren: review+, webkit-ews: commit-queue-

Mark Hahnenberg
Reported 2011-12-12 14:24:36 PST
We want to remove our dependence on the vptr being in the object prior to de-virtualizing all of the destructors. We'll use the ClassInfo* that is now in JSCell instead.
Attachments
Remove JSString vptr optimizations (25.03 KB, patch)
2011-12-12 14:47 PST, Mark Hahnenberg 		ggaren: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-12-12 14:47:06 PST
Created attachment 118856 [details] Remove JSString vptr optimizations No changelog, see bug 74331.
WebKit Review Bot
Comment 2 2011-12-12 14:49:56 PST
Attachment 118856 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.exp',..." exit_code: 1 Source/JavaScriptCore/jit/JITOpcodes.cpp:52: string_failureCases2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-12-12 14:57:39 PST
Comment on attachment 118856 [details] Remove JSString vptr optimizations I'm starting to think that the comments you're putting in bugzilla would make good ChangeLog comments, too.
Early Warning System Bot
Comment 4 2011-12-12 15:15:48 PST
Comment on attachment 118856 [details] Remove JSString vptr optimizations Attachment 118856 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10847094
Gyuyoung Kim
Comment 5 2011-12-12 16:17:20 PST
Comment on attachment 118856 [details] Remove JSString vptr optimizations Attachment 118856 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10847113
Gustavo Noronha (kov)
Comment 6 2011-12-12 20:00:36 PST
Comment on attachment 118856 [details] Remove JSString vptr optimizations Attachment 118856 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10848214
Note You need to log in before you can comment on or make changes to this bug.