Bug 74301 – [EFL] Add API to notify that mixed content has been loaded.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[EFL] Add API to notify that mixed content has been loaded.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 118795 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Created attachment 118799 [details]
Patch with bug number

[Raphael Kubo da Costa (:rakuco)]

Created attachment 118805 [details]
Move DocumentLoader.h include to bug 74302

[Gustavo Noronha (kov)]

Comment on attachment 118805 [details]
Move DocumentLoader.h include to bug 74302

View in context: https://bugs.webkit.org/attachment.cgi?id=118805&action=review

OK, looks good, with just a nit.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1706
> +        evas_object_smart_callback_call(ewkFrame, "mixedcontent,displayed", 0);
> +        ewk_view_mixed_content_displayed_set(smartData->view, true);

Wouldn't it be more conceptually correct to first set it, and then emit the signal? This way if the API user for some bizarre reason decides to query this flag while handling the signal it'll be properly set.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 118810 [details]
Patch for landing, follow kov's suggestion

[Raphael Kubo da Costa (:rakuco)]

Committed r102600: <http://trac.webkit.org/changeset/102600>