Bug 74010
| Summary: | [WK2] ShareableBitmap::paint() with scale factor is only implemented on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | dbates |
| Priority: | P4 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 64665 | ||
| Bug Blocks: | |||
Balazs Kelemen
Not sure this is a bug, but I would like to close the other two that deals with that.
So, this function is only called from PluginProxy like:
m_pluginBackingStore->paint(*graphicsContext, contentsScaleFactor(), IntPoint(), pluginBounds());
but the contensScaleFactor is only changing from 1 to any other value on Mac, like:
void PluginView::setDeviceScaleFactor(float scaleFactor)
{
if (!m_isInitialized || !m_plugin)
return;
m_plugin->contentsScaleFactorChanged(scaleFactor);
}
but this is a Mac only method right now. So we don't need to handle the "!= 1" case currently.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Balazs Kelemen
*** Bug 64665 has been marked as a duplicate of this bug. ***
Balazs Kelemen
*** Bug 64663 has been marked as a duplicate of this bug. ***
Balazs Kelemen
I'm implementing it for Qt in bug 98518.