Bug 64665 - [Cairo] Implement ShareableBitmap::paint() with scale factor
Summary: [Cairo] Implement ShareableBitmap::paint() with scale factor
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
Keywords: Cairo
Depends on:
Blocks: 74010
  Show dependency treegraph
Reported: 2011-07-16 21:43 PDT by Daniel Bates
Modified: 2014-04-10 12:03 PDT (History)
6 users (show)

See Also:

Patch (2.10 KB, patch)
2014-04-10 11:48 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-07-16 21:43:55 PDT
Implement the scale factor variant of ShareableBitmap::paint(). One such usage of this variant is in changeset <http://trac.webkit.org/changeset/91085>. In particular, the change to Source/WebKit2/UIProcess/FindIndicator.cpp.

For completeness, the scale factor variant of ShareableBitmap::paint() was added to the CG port in <http://trac.webkit.org/changeset/90198>.
Comment 1 Daniel Bates 2011-07-16 21:57:32 PDT
The WinCairo Debug build fails to compile because this variant of ShareableBitmap::paint() wasn't implemented for Cairo at the time changeset 91085 <http://trac.webkit.org/changeset/91085> landed:

5>libjpeg.lib(jdapistd.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
5>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/LTCG' specification
5>   Creating library D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.lib and object D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.exp
5>FindIndicator.obj : error LNK2001: unresolved external symbol "public: void __thiscall WebKit::ShareableBitmap::paint(class WebCore::GraphicsContext &,float,class WebCore::IntPoint const &,class WebCore::IntRect const &)" (?paint@ShareableBitmap@WebKit@@QAEXAAVGraphicsContext@WebCore@@MABVIntPoint@4@ABVIntRect@4@@Z)
5>D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\bin\WebKit_debug.dll : fatal error LNK1120: 1 unresolved externals
5>Build log was saved at "file://D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\obj\WebKit\BuildLog.htm"
5>WebKit - 2 error(s), 1 warning(s)

See <http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/8691/steps/compile-webkit/logs/stdio> for more details.

Committed sub method in <http://trac.webkit.org/changeset/91163>.
Comment 2 Balazs Kelemen 2011-12-07 10:45:07 PST

*** This bug has been marked as a duplicate of bug 74010 ***
Comment 3 Martin Robinson 2014-04-10 11:48:54 PDT
Reopening to attach new patch.
Comment 4 Martin Robinson 2014-04-10 11:48:58 PDT
Created attachment 229062 [details]
Comment 5 WebKit Commit Bot 2014-04-10 12:03:47 PDT
Comment on attachment 229062 [details]

Clearing flags on attachment: 229062

Committed r167080: <http://trac.webkit.org/changeset/167080>
Comment 6 WebKit Commit Bot 2014-04-10 12:03:51 PDT
All reviewed patches have been landed.  Closing bug.