Bug 73880

Summary: [MutationObservers] Support 'attributes' mutation records for element.removeAttribute
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: DOMAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, dglazkov, ojan, rniwa, vsevik, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73919    
Bug Blocks: 68729    
Attachments:
Description Flags
Patch none

Rafael Weinstein
Reported 2011-12-05 17:32:03 PST
element.removeAttribute should cause an 'attributes' mutation record to be enqueued for appropriate observers
Attachments
Patch (8.24 KB, patch)
2011-12-05 17:40 PST, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2011-12-05 17:40:24 PST
Created attachment 117963 [details] Patch
WebKit Review Bot
Comment 2 2011-12-05 23:37:23 PST
Comment on attachment 117963 [details] Patch Clearing flags on attachment: 117963 Committed r102100: <http://trac.webkit.org/changeset/102100>
WebKit Review Bot
Comment 3 2011-12-05 23:37:28 PST
All reviewed patches have been landed. Closing bug.
Vsevolod Vlasov
Comment 4 2011-12-06 06:40:05 PST
I think this change caused inspector/debugger/dom-breakpoints.html test to crash on chromium linux debug (assertion failed). https://bugs.webkit.org/show_bug.cgi?id=73919 Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2FmixedContent%2Finsecure-image-in-main-frame.html%2Cinspector%2Fdebugger%2Fdom-breakpoints.html
Dimitri Glazkov (Google)
Comment 5 2011-12-06 11:22:52 PST
Yes it did, let's revert this sucker.
Adam Klein
Comment 6 2011-12-06 11:26:34 PST
(In reply to comment #5) > Yes it did, let's revert this sucker. No need to revert for now, since this is behind ENABLE(MUTATION_OBSERVERS), which is not enabled on trunk (vsevik rolled it out the change to turn it on in http://trac.webkit.org/changeset/102141). I'm looking into the failure.
Note You need to log in before you can comment on or make changes to this bug.