Bug 73919 - Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux debug with ENABLE(MUTATION_OBSERVERS)
Summary: Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks: 73851 73880
  Show dependency treegraph
 
Reported: 2011-12-06 06:30 PST by Vsevolod Vlasov
Modified: 2011-12-07 12:04 PST (History)
9 users (show)

See Also:


Attachments
Patch (7.03 KB, patch)
2011-12-06 15:59 PST, Adam Klein
no flags Details | Formatted Diff | Diff
Move ifdef guards appropriately (7.91 KB, patch)
2011-12-06 16:35 PST, Adam Klein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-12-06 06:30:32 PST
The following layout test is failing on chromium linux debug

inspector/debugger/dom-breakpoints.html

Probable cause:

http://trac.webkit.org/changeset/102100/
Comment 1 Vsevolod Vlasov 2011-12-06 06:44:47 PST
Marked test as crashing for now: <http://trac.webkit.org/changeset/102133>
Comment 2 Vsevolod Vlasov 2011-12-06 09:06:54 PST
Removed expectations now that the original patch was rolled out.

Committed r102144: <http://trac.webkit.org/changeset/102144>
Comment 3 Adam Klein 2011-12-06 09:21:13 PST
Here's the stack trace

ASSERTION FAILED: s_currentDecl == decl
third_party/WebKit/Source/WebCore/css/CSSMutableStyleDeclaration.cpp(59) : WebCore::<unnamed>::StyleAttributeMutationScope::StyleAttributeMutationScope(WebCore::CSSMutableStyleDeclaration*)
1   0x109475c
2   0x109799d
3   0x10978d2
4   0x10e768e
5   0x183550e
6   0x6181ec62c01
[38988:38988:8694432581833:ERROR:process_util_posix.cc(139)] Received signal 11
	base::debug::StackTrace::StackTrace() [0x715496]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x6d1b8d]
	0x7f2cbffd8af0
	WebCore::(anonymous namespace)::StyleAttributeMutationScope::StyleAttributeMutationScope() [0x1094761]
	WebCore::CSSMutableStyleDeclaration::setProperty() [0x109799d]
	WebCore::CSSMutableStyleDeclaration::setProperty() [0x10978d2]
	WebCore::CSSStyleDeclaration::setProperty() [0x10e768e]
	WebCore::CSSStyleDeclarationInternal::setPropertyCallback() [0x183550e]
	0x6181ec62c01
Comment 4 Adam Klein 2011-12-06 15:59:46 PST
Created attachment 118131 [details]
Patch
Comment 5 Adam Klein 2011-12-06 16:04:14 PST
Adding pfeldman for inspector knowledge. In some cases, this patch will cause InspectorInstrumentation::didInvalidateStyleAttr() to be called slightly later, but it should still be called whenever it would have been called before.
Comment 6 Early Warning System Bot 2011-12-06 16:22:41 PST
Comment on attachment 118131 [details]
Patch

Attachment 118131 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10736895
Comment 7 Gyuyoung Kim 2011-12-06 16:34:37 PST
Comment on attachment 118131 [details]
Patch

Attachment 118131 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10746079
Comment 8 Adam Klein 2011-12-06 16:35:04 PST
Created attachment 118137 [details]
Move ifdef guards appropriately
Comment 9 WebKit Review Bot 2011-12-07 12:04:07 PST
Comment on attachment 118137 [details]
Move ifdef guards appropriately

Clearing flags on attachment: 118137

Committed r102264: <http://trac.webkit.org/changeset/102264>
Comment 10 WebKit Review Bot 2011-12-07 12:04:13 PST
All reviewed patches have been landed.  Closing bug.