Bug 73352

Summary: Use contentsToRootView when converting the mouse coordinates for the context menu key event
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71945    
Attachments:
Description Flags
Patch
none
Patch aroben: review+

Anders Carlsson
Reported 2011-11-29 12:52:29 PST
Use contentsToRootView when converting the mouse coordinate for the context menu key event
Attachments
Patch (1.54 KB, patch)
2011-11-29 12:53 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2011-11-29 13:23 PST, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-11-29 12:53:21 PST
Created attachment 117026 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-11-29 12:53:48 PST
Comment on attachment 117026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Why not?
Adam Roben (:aroben)
Comment 3 2011-11-29 12:54:14 PST
What is the symptom this patch fixes? Your bug title should describe it.
Anders Carlsson
Comment 4 2011-11-29 13:07:50 PST
(In reply to comment #2) > (From update of attachment 117026 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > Why not? This should already be covered by existing tests. (In reply to comment #3) > What is the symptom this patch fixes? Your bug title should describe it. Another part of https://bugs.webkit.org/show_bug.cgi?id=71945 - I'll relate the bugs and put the info in the change log.
Anders Carlsson
Comment 5 2011-11-29 13:23:00 PST
Created attachment 117033 [details] Patch
Adam Roben (:aroben)
Comment 6 2011-11-29 13:23:48 PST
Comment on attachment 117033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117033&action=review > Source/WebCore/ChangeLog:12 > + Use contentsToRootView when converting the mouse coordinates for the context menu key event > + https://bugs.webkit.org/show_bug.cgi?id=73352 > + > + Reviewed by NOBODY (OOPS!). > + > + This is another step towards fixing https://bugs.webkit.org/show_bug.cgi?id=71945, by getting > + rid of a call to ScrollView::contentsToWindow. > + > + * page/EventHandler.cpp: > + (WebCore::EventHandler::sendContextMenuEventForKey): You should mention why you haven't modified/added any tests.
Anders Carlsson
Comment 7 2011-11-29 13:30:35 PST
Committed r101416: <http://trac.webkit.org/changeset/101416>
Note You need to log in before you can comment on or make changes to this bug.