Summary: | [Qt] [WK2] Remove WebContext related code from QtWebPageProxy | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Component: | New Bugs | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hausmann, jesus, kenneth, menard, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 72943, 73151 | ||||||||
Attachments: |
|
Description
Caio Marcelo de Oliveira Filho
2011-11-25 16:17:14 PST
Created attachment 116643 [details]
Patch
Comment on attachment 116643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116643&action=review > Source/WebKit2/UIProcess/qt/QtWebContext.cpp:49 > +// Used only by WebKitTestRunner. Not calling initialize() so we don't register any clients. It avoids calling initialize(), so that we don't ... > Source/WebKit2/UIProcess/qt/QtWebContext.cpp:64 > + defaultContext->initialize(); > + return defaultContext.release(); I prefer a newline before the return. It makes it easier to spot that it returns something > Source/WebKit2/UIProcess/qt/QtWebContext.cpp:67 > +PassRefPtr<WebPageProxy> QtWebContext::createWebPage(PageClient* pageClient, WebPageGroup* webPageGroup) Personally I would just call the arguments for client and pageGroup. At least pageGroup should be enough > Source/WebKit2/UIProcess/qt/QtWebContext.cpp:72 > +void QtWebContext::setNavigatorQtObjectEnabled(WebPageProxy* webPageProxy, bool enabled) What about setNavigationDotQtJSObjectEnabled... It is hard to figure out what NavigationQt is all about > Source/WebKit2/UIProcess/qt/QtWebContext.cpp:98 > +void QtWebContext::setupContextInjectedBundleClient() Any reason this is called setup and not initialize? Created attachment 116649 [details]
Patch for landing
Comment on attachment 116643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116643&action=review Thanks for the review. Followed your suggestions in the version for landing -- except for one. >> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:72 >> +void QtWebContext::setNavigatorQtObjectEnabled(WebPageProxy* webPageProxy, bool enabled) > > What about setNavigationDotQtJSObjectEnabled... It is hard to figure out what NavigationQt is all about I have some work on navigator.qt object on the queue, so I'll fix that naming in a next patch. Comment on attachment 116649 [details] Patch for landing Clearing flags on attachment: 116649 Committed r101188: <http://trac.webkit.org/changeset/101188> All reviewed patches have been landed. Closing bug. |