Bug 73019

Summary: Web Inspector: split console agent into worker and page console agents
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 58541    
Attachments:
Description Flags
Patch pfeldman: review+

Yury Semikhatsky
Reported 2011-11-23 06:18:30 PST
Some console functionality is not supported in workers, e.g. addInspectedNode has no sense for worker since there is no DOM tree. I'd like to split the agent into worker and page specific descendants.
Attachments
Patch (54.02 KB, patch)
2011-11-23 06:23 PST, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-11-23 06:23:25 PST
Created attachment 116351 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-23 07:29:01 PST
Committed r101081: <http://trac.webkit.org/changeset/101081>
Timothy Hatcher
Comment 3 2011-11-23 18:21:53 PST
What is the bigger picture here? Do workers get their own Inspector?
Yury Semikhatsky
Comment 4 2011-11-23 22:17:26 PST
(In reply to comment #3) > What is the bigger picture here? Do workers get their own Inspector? Worker inspection meta bug describes this in details: https://bugs.webkit.org/show_bug.cgi?id=58541 At the moment we can list all dedicated workers in the Page's inspector and open separate inspector for each of them. It requires window.open to work inside inspector front-end on the platform. In WebKit2 it is blocked by https://bugs.webkit.org/show_bug.cgi?id=72506. Shared worker also can be inspected using its own web inspector. The idea is to have some discovery page for shared workers which would allow opening inspector front-end for each shared worker. In Chromium we use browser task manager for discovering shared worker processes and inspecting them.
Note You need to log in before you can comment on or make changes to this bug.