Bug 72988

Summary: Chromium API for creating and dispatching events has no unit tests
Product: WebKit Reporter: Dave Michael <dmichael>
Component: New BugsAssignee: Dave Michael <dmichael>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73736    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dave Michael
Reported 2011-11-22 15:45:32 PST
Chromium API for creating and dispatching events has no unit tests
Attachments
Patch (5.88 KB, patch)
2011-11-22 15:46 PST, Dave Michael 		no flags
DetailsFormatted DiffDiff
Patch (8.21 KB, patch)
2011-11-23 13:51 PST, Dave Michael 		no flags
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2011-11-23 13:54 PST, Dave Michael 		no flags
DetailsFormatted DiffDiff
Patch (8.18 KB, patch)
2011-12-02 14:36 PST, Dave Michael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dave Michael
Comment 1 2011-11-22 15:46:07 PST
Created attachment 116283 [details] Patch
Dave Michael
Comment 2 2011-11-23 13:51:06 PST
Created attachment 116417 [details] Patch
Dave Michael
Comment 3 2011-11-23 13:54:48 PST
Created attachment 116419 [details] Patch
Dave Michael
Comment 4 2011-11-23 14:05:11 PST
Comment on attachment 116419 [details] Patch Here's the test I promised for https://bugs.webkit.org/show_bug.cgi?id=71478
WebKit Review Bot
Comment 5 2011-12-02 14:23:48 PST
Comment on attachment 116419 [details] Patch Rejecting attachment 116419 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hing file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/WebKit.gypi Hunk #1 FAILED at 66. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/WebKit.gypi.rej patching file Source/WebKit/chromium/tests/DispatchEventTest.cpp patching file Source/WebKit/chromium/tests/data/event_target.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/10701418
Dave Michael
Comment 6 2011-12-02 14:36:55 PST
Created attachment 117693 [details] Patch
Dave Michael
Comment 7 2011-12-02 14:37:38 PST
Comment on attachment 117693 [details] Patch Sorry for the trouble; the old patch was quite old. This is just a merge.
WebKit Review Bot
Comment 8 2011-12-02 21:56:46 PST
Comment on attachment 117693 [details] Patch Clearing flags on attachment: 117693 Committed r101906: <http://trac.webkit.org/changeset/101906>
WebKit Review Bot
Comment 9 2011-12-02 21:56:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.