Summary: | Chromium API for creating and dispatching events has no unit tests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Michael <dmichael> | ||||||||||
Component: | New Bugs | Assignee: | Dave Michael <dmichael> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric, fishd, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 73736 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Dave Michael
2011-11-22 15:45:32 PST
Created attachment 116283 [details]
Patch
Created attachment 116417 [details]
Patch
Created attachment 116419 [details]
Patch
Comment on attachment 116419 [details] Patch Here's the test I promised for https://bugs.webkit.org/show_bug.cgi?id=71478 Comment on attachment 116419 [details] Patch Rejecting attachment 116419 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hing file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/WebKit.gypi Hunk #1 FAILED at 66. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/WebKit.gypi.rej patching file Source/WebKit/chromium/tests/DispatchEventTest.cpp patching file Source/WebKit/chromium/tests/data/event_target.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/10701418 Created attachment 117693 [details]
Patch
Comment on attachment 117693 [details]
Patch
Sorry for the trouble; the old patch was quite old. This is just a merge.
Comment on attachment 117693 [details] Patch Clearing flags on attachment: 117693 Committed r101906: <http://trac.webkit.org/changeset/101906> All reviewed patches have been landed. Closing bug. |