|Summary:||new-run-webkit-websocketserver must use Host().port_factory, too|
|Product:||WebKit||Reporter:||Takashi Toyoshima <toyoshim>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Major||CC:||abarth, eric, webkit.review.bot, yutak|
|Version:||528+ (Nightly build)|
Description Takashi Toyoshima 2011-11-20 23:23:33 PST
Eric landed a change related to port factory as follows. https://bugs.webkit.org/show_bug.cgi?id=71961 This change miss to fix new-run-webkit-websocketserver.
Comment 2 Eric Seidel (no email) 2011-11-20 23:28:44 PST
Comment on attachment 116033 [details] Patch Thank you. We should consider moving the guts of this script into webkitpy/websocketserver/main.py or similar to avoid breaking. Keeping our python code all under one directory makes dependency tracking easier.
Comment 3 Eric Seidel (no email) 2011-11-20 23:29:41 PST
I might also recommend putting the host in a local variable, as you're likely to want the filesystem or executive off it. Also, currently you have to call host._initialize_scm() after creating the host if you want it to have an SCM or Checkout object.
Comment 5 Takashi Toyoshima 2011-11-20 23:48:17 PST
Thank you Eric. For now, I just change to keep host in a local variable. We'll put them into webkitpy/websocketserver/... in future.
Comment 6 WebKit Review Bot 2011-11-21 01:12:23 PST
Comment on attachment 116035 [details] Patch Clearing flags on attachment: 116035 Committed r100889: <http://trac.webkit.org/changeset/100889>
Comment 7 WebKit Review Bot 2011-11-21 01:12:28 PST
All reviewed patches have been landed. Closing bug.