Bug 72859

Summary: new-run-webkit-websocketserver must use Host().port_factory, too
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: abarth, eric, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Takashi Toyoshima
Reported 2011-11-20 23:23:33 PST
Eric landed a change related to port factory as follows. https://bugs.webkit.org/show_bug.cgi?id=71961 This change miss to fix new-run-webkit-websocketserver.
Attachments
Patch (1.56 KB, patch)
2011-11-20 23:25 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-11-20 23:45 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-11-20 23:25:58 PST
Created attachment 116033 [details] Patch
Eric Seidel (no email)
Comment 2 2011-11-20 23:28:44 PST
Comment on attachment 116033 [details] Patch Thank you. We should consider moving the guts of this script into webkitpy/websocketserver/main.py or similar to avoid breaking. Keeping our python code all under one directory makes dependency tracking easier.
Eric Seidel (no email)
Comment 3 2011-11-20 23:29:41 PST
I might also recommend putting the host in a local variable, as you're likely to want the filesystem or executive off it. Also, currently you have to call host._initialize_scm() after creating the host if you want it to have an SCM or Checkout object.
Takashi Toyoshima
Comment 4 2011-11-20 23:45:16 PST
Created attachment 116035 [details] Patch
Takashi Toyoshima
Comment 5 2011-11-20 23:48:17 PST
Thank you Eric. For now, I just change to keep host in a local variable. We'll put them into webkitpy/websocketserver/... in future.
WebKit Review Bot
Comment 6 2011-11-21 01:12:23 PST
Comment on attachment 116035 [details] Patch Clearing flags on attachment: 116035 Committed r100889: <http://trac.webkit.org/changeset/100889>
WebKit Review Bot
Comment 7 2011-11-21 01:12:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.