Bug 72599

Summary: [GTK] Disable ref tests
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, pnormand, tony, webkit.review.bot, zan
Priority: P2    
Version: 312.x   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch xan.lopez: review+

Philippe Normand
Reported 2011-11-17 04:36:52 PST
http://trac.webkit.org/changeset/100326 made the GTK bots incredibly flaky, more than 40... Disabling ref tests fixes this issue, we should investigate this further and re-enable ref tests at some point but what we need now is stable bots. Thanks to Zan for the help on this.
Attachments
proposed patch (1.56 KB, patch)
2011-11-17 04:40 PST, Philippe Normand 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-11-17 04:40:26 PST
Created attachment 115563 [details] proposed patch
Xan Lopez
Comment 2 2011-11-17 04:47:39 PST
Comment on attachment 115563 [details] proposed patch OK. Please open a bug to track this, thanks!
Philippe Normand
Comment 3 2011-11-17 04:54:34 PST
Committed r100605: <http://trac.webkit.org/changeset/100605>
Tony Chang
Comment 4 2011-11-17 10:16:34 PST
Sorry about that! I'll see if I can repro.
Zan Dobersek
Comment 5 2011-11-17 11:42:33 PST
(In reply to comment #4) > Sorry about that! I'll see if I can repro. A basic patch that fixes this is up at bug #72601. It's more of a quick hack, but the problem was that DriverProxy created two drivers, both using the same Xvfb instance, which caused the flakiness.
Note You need to log in before you can comment on or make changes to this bug.