Bug 72577

Summary: Remove all custom constructors of Events from JSC
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, japhet, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71379    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2011-11-16 18:57:02 PST
Now CodeGeneratorV8.pm can generate Event constructors using [ConstructorTemplate=Event] IDL (bug 72055). CodeGeneratorJS.pm should also generate Event constructors by the IDL. By doing this, we can remove EventConstructors.h and JSEventConstructors.cpp.
Attachments
Patch (48.39 KB, patch)
2011-11-16 22:26 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-16 22:26:40 PST
Created attachment 115525 [details] Patch
Adam Barth
Comment 2 2011-11-16 22:31:54 PST
Comment on attachment 115525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115525&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3249 > + if (IsConstructorTemplate($dataNode, "Event")) { I might have called IsConstructorTemplate something like HasConstructorTemplate, but it's probably better to be consistent with the V8 code generator.
WebKit Review Bot
Comment 3 2011-11-16 23:11:52 PST
Comment on attachment 115525 [details] Patch Clearing flags on attachment: 115525 Committed r100564: <http://trac.webkit.org/changeset/100564>
WebKit Review Bot
Comment 4 2011-11-16 23:11:57 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 5 2011-11-17 06:39:18 PST
*** Bug 72255 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.