Summary: | Text tracks should be treated differently according to their kind | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anna Cavender <annacc> | ||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dw.im, eric.carlson, rniwa, webkit-bug-importer, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43668 | ||||||||
Attachments: |
|
Description
Anna Cavender
2011-11-16 14:25:45 PST
Created attachment 118880 [details]
Proposed patch
Attachment 118880 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1
Source/WebCore/html/HTMLMediaElement.h:203: The parameter name "trackElement" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119286 [details]
Updated patch
Update patch as Alexey pointed out that track selection logic should not run until the media element has been closed.
Comment on attachment 119286 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=119286&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2296 > + Settings* settings = document()->settings(); > + You could pull the settings null check up here and avoid the duplication below. (In reply to comment #5) > (From update of attachment 119286 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119286&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:2296 > > + Settings* settings = document()->settings(); > > + > > You could pull the settings null check up here and avoid the duplication below. Thanks, I will fix that in a follow up patch so I can use the commit-queue on this one. Or not. Committed by hand so I can get on with things. http://trac.webkit.org/changeset/102968 Mac rebaseline done in http://trac.webkit.org/changeset/103642. |