Summary: | REGRESSION(r100213): "Breaks test_shell_tests" (Requested by tonyg-cr on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, tonyg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 72308 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-11-15 03:07:10 PST
Created attachment 115135 [details] ROLLOUT of r100213 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. I believe the patch is good, but unfortunately several tests were relying on the former loopholes. In order to avoid losing test coverage in the meantime and keep things rolling forward, I decided it is best to roll back for now. Sorry for the inconvenience. Here's an example of the test_shell_tests that failed: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/16479/steps/test_shell_tests Comment on attachment 115135 [details] ROLLOUT of r100213 Clearing flags on attachment: 115135 Committed r100262: <http://trac.webkit.org/changeset/100262> All reviewed patches have been landed. Closing bug. As far as I can tell, all of these tests are wrong. |