media/track/track-webvtt-tc003-newlines.html is flaky

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Tony Gentilcore]

media/track/track-webvtt-tc003-newlines.html has been flaky since it was introduced by r100085.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-webvtt-tc003-newlines.html

I'm marking it flaky for now.

[Tony Gentilcore]

Created attachment 115131 [details]
Patch

[Tony Gentilcore]

Committed r100257: <http://trac.webkit.org/changeset/100257>

[Anna Cavender]

Created attachment 115191 [details]
Patch

change guarantees tests will run in order

[Tony Gentilcore]

Comment on attachment 115191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115191&action=review

Thanks again for jumping on this flakiness so quickly.

A couple of minor suggestions inline.

> LayoutTests/media/track/track-webvtt-tc003-newlines.html:14
> +                numberOfTracksLoaded++;

Probably best to "var numberOfTracksLoaded = 0" up on line 9 or 10.

> LayoutTests/media/track/track-webvtt-tc003-newlines.html:17
> +                    testTrack(1);

This is a bit more future proof and the same number of lines:

for (var i = 0; i < numberOfTrackTests; i++)
    testTrack(i);

[Anna Cavender]

Created attachment 115193 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 115193 [details]
Patch for landing

Clearing flags on attachment: 115193

Committed r100299: <http://trac.webkit.org/changeset/100299>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.