Bug 72269

Summary:

media/track/track-cues-cuechange.html is flaky

Product:

WebKit

Reporter:

Tony Gentilcore <tonyg>

Component:

WebCore Misc.

Assignee:

Anna Cavender <annacc>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, imasaki, pkasting, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

43668, 70452

Attachments:

Description	Flags
Patch	none
change tests to check for order rather than timing	none
Patch for landing	none
make sure both video and track are ready to be tested	none
Patch for landing	webkit.review.bot: commit-queue-

Tony Gentilcore

Reported 2011-11-14 06:39:37 PST

media/track/track-cues-cuechange.html has been flaky on all platforms (for chromium at least) since it was introduced by r100064. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-cues-cuechange.html I'm going to mark it flaky for now.

Attachments
Patch (1.43 KB, patch) 2011-11-14 06:41 PST, Tony Gentilcore	no flags	Details Formatted Diff Diff
change tests to check for order rather than timing (11.08 KB, patch) 2011-11-14 12:24 PST, Anna Cavender	no flags	Details Formatted Diff Diff
Patch for landing (11.55 KB, patch) 2011-11-15 10:07 PST, Anna Cavender	no flags	Details Formatted Diff Diff
make sure both video and track are ready to be tested (6.20 KB, patch) 2011-11-15 17:31 PST, Anna Cavender	no flags	Details Formatted Diff Diff
Patch for landing (6.09 KB, patch) 2011-11-15 18:17 PST, Anna Cavender	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Tony Gentilcore

Comment 1 2011-11-14 06:41:38 PST

Created attachment 114937 [details] Patch

Tony Gentilcore

Comment 2 2011-11-14 06:53:50 PST

Committed r100139: <http://trac.webkit.org/changeset/100139>

Anna Cavender

Comment 3 2011-11-14 12:24:00 PST

Created attachment 115003 [details] change tests to check for order rather than timing

Anna Cavender

Comment 4 2011-11-15 10:07:20 PST

Created attachment 115187 [details] Patch for landing

WebKit Review Bot

Comment 5 2011-11-15 11:15:11 PST

Comment on attachment 115187 [details] Patch for landing Clearing flags on attachment: 115187 Committed r100296: <http://trac.webkit.org/changeset/100296>

WebKit Review Bot

Comment 6 2011-11-15 11:15:16 PST

All reviewed patches have been landed. Closing bug.

Peter Kasting

Comment 7 2011-11-15 16:39:07 PST

This patch made things worse rather than better, at least for the WebKit Mac 10.6 (CG) canary, where this patch made this test suddenly become much more flaky. I'm going to re-mark this test as flaky.

Anna Cavender

Comment 8 2011-11-15 17:13:30 PST

Good catch. Looks like this test needs to wait for both canplaythrough AND loaded (on <track>) the same way media/track/track-cues-seeking.html does. I'm on it.

Anna Cavender

Comment 9 2011-11-15 17:31:26 PST

Created attachment 115287 [details] make sure both video and track are ready to be tested

Anna Cavender

Comment 10 2011-11-15 18:17:44 PST

Created attachment 115291 [details] Patch for landing

WebKit Review Bot

Comment 11 2011-11-15 18:53:19 PST

Comment on attachment 115291 [details] Patch for landing Rejecting attachment 115291 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10361573

Anna Cavender

Comment 12 2011-11-15 21:33:50 PST

Committed r100402: <http://trac.webkit.org/changeset/100402>

Note You need to log in before you can comment on or make changes to this bug.