Bug 72045

Summary: Remove ability to call HTMLCollections in V8 bindings as well.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, darin, eric, japhet, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Proposed patch andersca: review+

Andreas Kling
Reported 2011-11-10 12:39:24 PST
Bug 67579 removed the ability to call HTMLCollections (excluding HTMLAllCollection) via the JSC bindings. Let's try the same for the V8 bindings. Patch coming..
Attachments
Patch for EWS (5.24 KB, patch)
2011-11-10 12:44 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch (9.19 KB, patch)
2011-11-11 05:14 PST, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-11-10 12:44:11 PST
Created attachment 114547 [details] Patch for EWS
Darin Adler
Comment 2 2011-11-10 12:44:51 PST
You don’t need to submit a patch for review to submit it for EWS any more. Do you?
Andreas Kling
Comment 3 2011-11-10 12:45:58 PST
(In reply to comment #2) > You don’t need to submit a patch for review to submit it for EWS any more. Do you? Oh, I didn't realize. Sorry about that.
Adam Barth
Comment 4 2011-11-10 14:30:51 PST
Comment on attachment 114547 [details] Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=114547&action=review > Source/WebCore/ChangeLog:17 > + Remove the V8CustomCall attribute as it's no longer needed. Are there tests that show that these interfaces are no longer callable? (Other than that, this looks great.)
Andreas Kling
Comment 5 2011-11-11 05:14:06 PST
Created attachment 114679 [details] Proposed patch
Andreas Kling
Comment 6 2011-11-11 06:38:15 PST
Committed r99958: <http://trac.webkit.org/changeset/99958>
Note You need to log in before you can comment on or make changes to this bug.