Bug 71961

Summary: Make the Port object have a Host
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71983    
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue+

Eric Seidel (no email)
Reported 2011-11-09 15:29:26 PST
Make the Port object have a Host
Attachments
Patch (84.53 KB, patch)
2011-11-09 15:34 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-11-09 15:34:07 PST
Created attachment 114379 [details] Patch
Adam Barth
Comment 2 2011-11-09 15:38:15 PST
Comment on attachment 114379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114379&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:90 > + port_name=None, options=None, Separate lines? > Tools/Scripts/webkitpy/layout_tests/port/factory.py:126 > + host = host or self._host I would have put this at the top of the function, but whatever.
Eric Seidel (no email)
Comment 3 2011-11-09 15:41:00 PST
Committed r99773: <http://trac.webkit.org/changeset/99773>
Note You need to log in before you can comment on or make changes to this bug.