Bug 71961

Summary:

Make the Port object have a Host

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

71983

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue+

Description Eric Seidel (no email) 2011-11-09 15:29:26 PST

Make the Port object have a Host

Comment 1 Eric Seidel (no email) 2011-11-09 15:34:07 PST

Created attachment 114379 [details]
Patch

Comment 2 Adam Barth 2011-11-09 15:38:15 PST

Comment on attachment 114379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114379&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:90
> +                 port_name=None, options=None,

Separate lines?

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:126
> +        host = host or self._host

I would have put this at the top of the function, but whatever.

Comment 3 Eric Seidel (no email) 2011-11-09 15:41:00 PST

Committed r99773: <http://trac.webkit.org/changeset/99773>