Bug 71832

Summary:

[meta] Remove [CanBeConstructed] IDL

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

DOM

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dominicc, japhet, macpherson, ojan, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

71868, 71871, 71927, 71938

Bug Blocks:

Attachments:

Description	Flags
WIP patch	none

Kentaro Hara

Reported 2011-11-08 10:18:38 PST

Now we have [Constructor] IDL for both JSC and V8. We can remove [CanBeConstructed] IDL, which is not a speced Web IDL. - If a class has both [CanBeConstructed] and [Constructor] IDL, we can just remove [CanBeConstructed] IDL from the class. - If a class has [CanBeConstructed] IDL but does not have [Constructor] IDL, we can add [Constructor] IDL and remove [CanBeConstructed] IDL. - We can remove V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext.

Attachments
WIP patch (44.95 KB, patch) 2011-11-08 15:44 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2011-11-08 15:44:15 PST

Created attachment 114165 [details] WIP patch

Kentaro Hara

Comment 2 2011-11-08 15:50:09 PST

I uploaded a WIP patch. I am planning to land it in the following steps: [1] Just remove [CanBeConstructed] IDL from the following IDLs. Event.idl, Worker.idl, ErrorEvent.idl, CustomEvent.idl, EventSource.idl, WebKitCSSMatrix.idl, WebKitPoint.idl, OverFlowEvent.idl, AudioContext.idl, DOMFormData.idl, PopStateEvent.idl, MessageEvent.idl, XMLHttpRequest.idl, DataView.idl, ProgressEvent.idl, WebSocket.idl, HashChangeEvent.idl, XSLTProcessor.idl, TextTrackCue.idl, PeerConnection.idl, Int16Array.idl, Float64Array.idl, WebKitAnimationEvent.idl, WebKitMutationObserver.idl, PageTransitionEvent.idl, BeforeLoadEvent.idl, MessageChannel.idl, WebKitTransitionEvent.idl, CloseEvent.idl, SharedWorker.idl, TrackEvent.idl, Int32Array.idl, ArrayBuffer.idl, Float32Array.idl, Int8Array.idl, Uint32Array.idl, Uint16Array.idl, Uint8Array.idl [2] Replaced [CanBeConstructed] IDL with [Constructor] IDL in the following IDLs. DOMParser.idl, WebKitFlags.idl, XMLSerializer.idl, XPathEvaluator.idl, FileReader.idl FileReaderSync.idl, WebKitBlobBuilder.idl [3] Remove [CanBeConstructed] related code from CodeGeneratorJS.pm [4] Remove [CanBeConstructed] related code from CodeGeneratorV8.pm

Adam Barth

Comment 3 2011-11-08 16:10:42 PST

> I am planning to land it in the following steps: Those sound like good steps.

Kentaro Hara

Comment 4 2011-11-09 17:42:48 PST

All patches were landed.

Note You need to log in before you can comment on or make changes to this bug.