Bug 71423

Summary:

Remove all releaseRef implementations except for RetainPtr

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jchaffraix, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

41374

Attachments:

Description	Flags
Patch	none

Description Darin Adler 2011-11-02 17:13:43 PDT

Last step in renaming releaseRef to leakRef.

Comment 1 Darin Adler 2011-11-10 08:26:52 PST

Created attachment 114508 [details]
Patch

Comment 2 Julien Chaffraix 2011-11-10 12:05:56 PST

Comment on attachment 114508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114508&action=review

> Source/JavaScriptCore/API/JSRetainPtr.h:-75
> -    T releaseRef() { return leakRef(); }

I guess you have discussed this API breakage.

Comment 3 Darin Adler 2011-11-10 12:07:50 PST

(In reply to comment #2)
> I guess you have discussed this API breakage.

Is JSRetainPtr API? On what platforms?

Comment 4 Julien Chaffraix 2011-11-10 12:13:13 PST

(In reply to comment #3)
> (In reply to comment #2)
> > I guess you have discussed this API breakage.
> 
> Is JSRetainPtr API? On what platforms?

I thought it was exposed to the JSC API but it is actually not exposed.

Comment 5 WebKit Review Bot 2011-11-11 14:52:15 PST

Comment on attachment 114508 [details]
Patch

Clearing flags on attachment: 114508

Committed r100030: <http://trac.webkit.org/changeset/100030>

Comment 6 WebKit Review Bot 2011-11-11 14:52:19 PST

All reviewed patches have been landed.  Closing bug.