Bug 71344

Summary: Remove initMediaStreamEvent method
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, kaustubh.ra, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71345    
Bug Blocks: 68791    
Attachments:
Description Flags
Patch none

Description Dominic Cooney 2011-11-01 18:08:51 PDT 
This method has been removed from the spec draft:

<http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent>

Code Search does not turn up any users: <http://codesearch.google.com/#search/&q=initMediaStreamEvent&type=cs> Since this is new, it is probably safe to remove it when MediaStreamEvent gets a constructor.
Comment 1 Dominic Cooney 2011-11-01 18:12:58 PDT 
Bug 71345 is tracking implementing the MediaStreamEvent constructor.
Comment 2 Kaustubh Atrawalkar 2011-11-04 05:19:23 PDT 
Created attachment 113649 [details]
Patch
Comment 3 Kaustubh Atrawalkar 2011-11-04 05:19:51 PDT 
Added patch for removing initMediaStreamEvent method.
Comment 4 Dominic Cooney 2011-11-04 09:13:29 PDT 
Comment on attachment 113649 [details]
Patch

The patch looks good to me. You may want to hold off landing this until the MediaStreamEvent constructor is implemented (see bug 71345) otherwise there will be no way to programatically dispatch a MediaStreamEvent.
Comment 5 Adam Barth 2011-11-04 10:03:43 PDT 
Comment on attachment 113649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113649&action=review

I think its fine to land without the constructor.  This feature isn't shipping in any port that I'm aware of.

> Source/WebCore/ChangeLog:11
> +        No new tests. Removed method.

You can test that this method doesn't exist!  That will catch us if someone tries to add it back.
Comment 6 WebKit Review Bot 2011-11-04 11:12:02 PDT 
Comment on attachment 113649 [details]
Patch

Clearing flags on attachment: 113649

Committed r99299: <http://trac.webkit.org/changeset/99299>
Comment 7 WebKit Review Bot 2011-11-04 11:12:07 PDT 
All reviewed patches have been landed.  Closing bug.