Bug 71156

Summary: More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Jeff Miller
Reported 2011-10-28 16:04:14 PDT
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
Attachments
Patch (1.82 KB, patch)
2011-10-28 16:08 PDT, Jeff Miller 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-10-28 16:05:28 PDT
Follow up to bug 70943, where Alexey commented: > There is also PDF code in WebContext::platformInitializeWebProcess. Should that be conditional, too?
Jeff Miller
Comment 2 2011-10-28 16:08:28 PDT
Created attachment 112936 [details] Patch
Alexey Proskuryakov
Comment 3 2011-10-28 16:18:54 PDT
Comment on attachment 112936 [details] Patch What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime?
Jeff Miller
Comment 4 2011-10-28 16:31:29 PDT
(In reply to comment #3) > (From update of attachment 112936 [details]) > What was the manifestation of this problem, and are we sure that omitPDFSupport() will return the correct result so early in context lifetime? There was no end-user symptom, PDF support was disabled correctly when this pref was set with the previous patch in r98513. This is just being complete by not including these MIME types in the initialization message. omitPDFSupport() just reads a preference from the standard user defaults, which should definitely be OK when this is called (note that this code is in the UI process, not the web process which is being created).
Jeff Miller
Comment 5 2011-10-28 16:35:19 PDT
Committed r98781: <http://trac.webkit.org/changeset/98781>
Note You need to log in before you can comment on or make changes to this bug.