Bug 70908

Summary:

[GTK] Remove g_thread_init() calls from gtk-doc scanner too

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	gustavo: review+

Carlos Garcia Campos

Reported 2011-10-26 05:26:38 PDT

I forgot to remove g_thread_init from gtk-doc scanner too. See also bug #70717

Attachments
Patch (2.39 KB, patch) 2011-10-26 05:28 PDT, Carlos Garcia Campos	gustavo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2011-10-26 05:28:42 PDT

Created attachment 112484 [details] Patch

Gustavo Noronha (kov)

Comment 2 2011-10-26 05:30:09 PDT

Comment on attachment 112484 [details] Patch Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise!

WebKit Review Bot

Comment 3 2011-10-26 05:30:16 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 4 2011-10-26 05:35:40 PDT

(In reply to comment #2) > (From update of attachment 112484 [details]) > Do we already depend (via configure.ac) on a new enough glib, btw? Worth double checking, LGTM otherwise! Yes, we already checked it for bug #70717. Thanks!

Carlos Garcia Campos

Comment 5 2011-10-26 05:38:14 PDT

Committed r98465: <http://trac.webkit.org/changeset/98465>

Note You need to log in before you can comment on or make changes to this bug.