Bug 70312

Summary: [EFL][WK2] Added missing files to build WebKit2 EFL
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch 2 none

Description Tomasz Morawski 2011-10-18 00:22:51 PDT 
Added missing files to build WebKit2 EFL to fix few linking time errors.
Comment 1 Tomasz Morawski 2011-10-18 00:25:30 PDT 
Created attachment 111400 [details]
Patch
Comment 2 Leandro Pereira 2011-10-18 06:28:19 PDT 
Comment on attachment 111400 [details]
Patch

LGTM. Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry.
Comment 3 Tomasz Morawski 2011-10-18 06:41:59 PDT 
Created attachment 111432 [details]
Patch 2
Comment 4 Tomasz Morawski 2011-10-18 06:42:43 PDT 
> Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry
Chamgelog has been changed.
Comment 5 Ryosuke Niwa 2011-10-18 23:41:54 PDT 
Comment on attachment 111432 [details]
Patch 2 

You didn't svn add files :(
Comment 6 Ryosuke Niwa 2011-10-18 23:43:22 PDT 
Comment on attachment 111432 [details]
Patch 2 

Oops I take back. These files do exist. r=me.
Comment 7 WebKit Review Bot 2011-10-19 01:31:37 PDT 
Comment on attachment 111432 [details]
Patch 2 

Clearing flags on attachment: 111432

Committed r97841: <http://trac.webkit.org/changeset/97841>
Comment 8 WebKit Review Bot 2011-10-19 01:31:41 PDT 
All reviewed patches have been landed.  Closing bug.