Bug 70312

Summary: [EFL][WK2] Added missing files to build WebKit2 EFL
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch 2 none

Tomasz Morawski
Reported 2011-10-18 00:22:51 PDT
Added missing files to build WebKit2 EFL to fix few linking time errors.
Attachments
Patch (1.14 KB, patch)
2011-10-18 00:25 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.33 KB, patch)
2011-10-18 06:41 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-10-18 00:25:30 PDT
Created attachment 111400 [details] Patch
Leandro Pereira
Comment 2 2011-10-18 06:28:19 PDT
Comment on attachment 111400 [details] Patch LGTM. Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry.
Tomasz Morawski
Comment 3 2011-10-18 06:41:59 PDT
Created attachment 111432 [details] Patch 2
Tomasz Morawski
Comment 4 2011-10-18 06:42:43 PDT
> Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry Chamgelog has been changed.
Ryosuke Niwa
Comment 5 2011-10-18 23:41:54 PDT
Comment on attachment 111432 [details] Patch 2 You didn't svn add files :(
Ryosuke Niwa
Comment 6 2011-10-18 23:43:22 PDT
Comment on attachment 111432 [details] Patch 2 Oops I take back. These files do exist. r=me.
WebKit Review Bot
Comment 7 2011-10-19 01:31:37 PDT
Comment on attachment 111432 [details] Patch 2 Clearing flags on attachment: 111432 Committed r97841: <http://trac.webkit.org/changeset/97841>
WebKit Review Bot
Comment 8 2011-10-19 01:31:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.