Bug 70192

Summary: Remove unused ENABLE(SKIA_GPU)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric, jamesr, junov, kbr, kennyluck, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68012    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-10-15 19:08:35 PDT
Remove unused ENABLE(SKIA_GPU)
Attachments
Patch (1.31 KB, patch)
2011-10-15 19:09 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-15 19:09:29 PDT
Created attachment 111163 [details] Patch
Daniel Bates
Comment 2 2011-10-15 19:42:22 PDT
Comment on attachment 111163 [details] Patch For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi.
WebKit Review Bot
Comment 3 2011-10-15 21:19:03 PDT
Comment on attachment 111163 [details] Patch Clearing flags on attachment: 111163 Committed r97570: <http://trac.webkit.org/changeset/97570>
WebKit Review Bot
Comment 4 2011-10-15 21:19:07 PDT
All reviewed patches have been landed. Closing bug.
Kang-Hao (Kenny) Lu
Comment 5 2013-03-28 20:24:54 PDT
(In reply to comment #2) > (From update of attachment 111163 [details]) > For completeness, references to ENABLE(SKIA_GPU) were replaced with USE(SKIA) or an analogous run-time check in <http://trac.webkit.org/changeset/85017>. Obviously, we didn't remove SKIA_GPU references in Source/WebKit/chromium/features.gypi. It seems that ENABLE_RUBY, introduced temporarily by Bug 28420, was not removed from features.gypi either. I am not sure about ENABLE_SANDBOX, V8_SCRIPT_DEBUG_SERVER. These two were introduced in r88548 but there are not listed on http://trac.webkit.org/wiki/FeatureFlags .
Note You need to log in before you can comment on or make changes to this bug.