Bug 70189

Summary: Always enable ENABLE(DOM_STORAGE)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68012    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Adam Barth 2011-10-15 17:26:24 PDT 
Always enable ENABLE(DOM_STORAGE)
Comment 1 Adam Barth 2011-10-15 17:28:43 PDT 
Created attachment 111156 [details]
Patch
Comment 2 Early Warning System Bot 2011-10-15 17:42:07 PDT 
Comment on attachment 111156 [details]
Patch

Attachment 111156 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10076370
Comment 3 Adam Barth 2011-10-15 17:50:01 PDT 
Created attachment 111158 [details]
Patch
Comment 4 Early Warning System Bot 2011-10-15 18:03:48 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10075359
Comment 5 Gyuyoung Kim 2011-10-15 18:24:58 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10078377
Comment 6 WebKit Review Bot 2011-10-15 18:27:49 PDT 
Comment on attachment 111158 [details]
Patch

Attachment 111158 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10079288
Comment 7 Adam Barth 2011-10-15 18:28:44 PDT 
Created attachment 111161 [details]
Patch
Comment 8 WebKit Review Bot 2011-10-15 19:32:57 PDT 
Comment on attachment 111161 [details]
Patch

Attachment 111161 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10077383

New failing tests:
storage/domstorage/sessionstorage/window-open.html
Comment 9 WebKit Review Bot 2011-10-15 20:28:13 PDT 
Comment on attachment 111161 [details]
Patch

Attachment 111161 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10073458

New failing tests:
storage/domstorage/sessionstorage/window-open.html
Comment 10 Adam Barth 2011-10-15 20:59:17 PDT 
Created attachment 111173 [details]
Patch
Comment 11 Eric Seidel (no email) 2011-10-16 02:04:20 PDT 
Comment on attachment 111173 [details]
Patch

SGTM.
Comment 12 WebKit Review Bot 2011-10-16 03:29:15 PDT 
Comment on attachment 111173 [details]
Patch

Clearing flags on attachment: 111173

Committed r97574: <http://trac.webkit.org/changeset/97574>
Comment 13 WebKit Review Bot 2011-10-16 03:29:20 PDT 
All reviewed patches have been landed.  Closing bug.