| Summary: | land-cowboy should at least check style. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2011-10-13 16:38:49 PDT
Created attachment 110930 [details]
Patch
This has bitten me for the last time! Comment on attachment 110930 [details]
Patch
Ok. I relent. In the past, my position has been that cowboys don't check style, but I have to admit now that this command has passed into more common usage and not everyone who uses it is a real cowboy.
We should a command called land-cowboy-for-realz that skips CheckStyle and ConfirmDiff. :)
Comment on attachment 110930 [details] Patch Clearing flags on attachment: 110930 Committed r97427: <http://trac.webkit.org/changeset/97427> All reviewed patches have been landed. Closing bug. abarth@quadzen:~/svn/webkit$ wkp land-cowboy Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Change author: Adam Barth <abarth@webkit.org>. Running 'svn update' to update ChangeLog files. At revision 97439. Editing the LayoutTests/ChangeLog file. -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files Are you sure you want to continue? [Y/n]: Was that diff correct? [Y/n]: Can we silence that warning? It's bogus for land-cowboy. (In reply to comment #7) > Can we silence that warning? It's bogus for land-cowboy. Makes sense. Lemme see what I can do. |