Bug 70016

Summary: [WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError.
Product: WebKit Reporter: Nayan Kumar K <nayankk>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 70040    
Attachments:
Description Flags
Add missing documentation
mrobinson: review-
Add missing documentation none

Description Nayan Kumar K 2011-10-13 04:33:04 PDT 
Documentation is missing for WebKitPluginError and WebKitPolicyError
Comment 1 Nayan Kumar K 2011-10-13 04:43:36 PDT 
Created attachment 110826 [details]
Add missing documentation
Comment 2 Martin Robinson 2011-10-13 08:32:51 PDT 
Comment on attachment 110826 [details]
Add missing documentation

View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review

Looks good, except for one small nit.

> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58
> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown

url should actually say "URI"

This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug.
Comment 3 Nayan Kumar K 2011-10-13 10:57:55 PDT 
Created attachment 110879 [details]
Add missing documentation
Comment 4 Nayan Kumar K 2011-10-13 10:59:17 PDT 
Comment on attachment 110826 [details]
Add missing documentation

View in context: https://bugs.webkit.org/attachment.cgi?id=110826&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitError.h:58
>> + * @WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL: Load failure due to url that can not be shown
> 
> url should actually say "URI"
> 
> This also suggests that we should rename WEBKIT_POLICY_ERROR_CANNOT_SHOW_URL to WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI in another bug.

Bug https://bugs.webkit.org/show_bug.cgi?id=70040has been raised to rename this enum. I will submit the patch for this rename soon.
Comment 5 WebKit Review Bot 2011-10-14 13:57:18 PDT 
Comment on attachment 110879 [details]
Add missing documentation

Clearing flags on attachment: 110879

Committed r97503: <http://trac.webkit.org/changeset/97503>
Comment 6 WebKit Review Bot 2011-10-14 13:57:22 PDT 
All reviewed patches have been landed.  Closing bug.