Bug 69917

Summary: Bug summary for Chromium DEPS roll to LKGR doesn't include revision number
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Tools / TestsAssignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
abarth: review-
Comments addressed, test added
none
Style fixed none

Description Mikhail Naganov 2011-10-12 03:56:20 PDT
Bug summary says "Roll Chromium DEPS to r[]", e.g. see https://bugs.webkit.org/show_bug.cgi?id=69916
Comment 1 Mikhail Naganov 2011-10-12 04:13:03 PDT
Created attachment 110663 [details]
Patch

Looks like really fetching LKGR number at this step is hard, so let's just say "to last-known good revision", as bot says on IRC.
Comment 2 Adam Barth 2011-10-12 09:32:05 PDT
Comment on attachment 110663 [details]
Patch

Please update argument_names as well.

Did you run ./Tools/Scripts/test-webkitpy ?  We like to add tests whenever we make a change to webkitpy.
Comment 3 Adam Barth 2011-10-12 09:52:08 PDT
Comment on attachment 110663 [details]
Patch

This patch looks correct, but I think we'll want a test.  You can look in irc_command_unittest for examples.  We don't need an end-to-end test here, just something simple.
Comment 4 Mikhail Naganov 2011-10-12 14:20:45 PDT
Created attachment 110744 [details]
Comments addressed, test added

Wow, didn't expected such a rich framework here!
Comment 5 WebKit Review Bot 2011-10-12 14:23:28 PDT
Attachment 110744 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/tool/commands/roll_unittest.py:52:  expected 2 blank lines, found 1  [pep8/E302] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Mikhail Naganov 2011-10-12 14:26:01 PDT
Created attachment 110745 [details]
Style fixed
Comment 7 Mikhail Naganov 2011-10-24 15:29:58 PDT
Adam, can you please take another look?
Comment 8 Adam Barth 2011-10-24 19:00:50 PDT
Comment on attachment 110745 [details]
Style fixed

Thanks!
Comment 9 WebKit Review Bot 2011-10-24 20:35:32 PDT
Comment on attachment 110745 [details]
Style fixed

Clearing flags on attachment: 110745

Committed r98315: <http://trac.webkit.org/changeset/98315>
Comment 10 WebKit Review Bot 2011-10-24 20:35:37 PDT
All reviewed patches have been landed.  Closing bug.