Bug 69486

Summary: watchlist: Should be more robust to bad regex.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, levin+watchlist, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 70358    
Bug Blocks: 68822    
Attachments:
Description Flags
Patch none

David Levin
Reported 2011-10-05 17:26:53 PDT
It is easy to enter a bad regex for a definition, etc. We shouldn't turn every style run red and other definitions should still be run.
Attachments
Patch (19.57 KB, patch)
2011-10-18 20:31 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-10-18 20:31:08 PDT
Created attachment 111556 [details] Patch
Adam Barth
Comment 2 2011-10-19 12:37:45 PDT
Comment on attachment 111556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111556&action=review > Tools/Scripts/webkitpy/common/watchlist/amountchangedpattern.py:32 > + def __init__(self, compile_regex, index_for_zero_value): > + self._regex = compile_regex compile_regex => compiled_regex ? > Tools/Scripts/webkitpy/common/watchlist/changedlinepattern.py:32 > + def __init__(self, compile_regex, index_for_zero_value): > + self._regex = compile_regex Same question. > Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:114 > + except Exception, e: Can we catch a more specific exception here? I bet there's a specific exception for regexes failing to compile.
WebKit Review Bot
Comment 3 2011-10-19 15:32:47 PDT
Comment on attachment 111556 [details] Patch Clearing flags on attachment: 111556 Committed r97885: <http://trac.webkit.org/changeset/97885>
WebKit Review Bot
Comment 4 2011-10-19 15:32:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.