Bug 69397
| Summary: | Focus rings are missing in WebKitTestRunner snapshots | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | jonlee, sam, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
In WebKitTestRunner pixel results, form controls don't look highlighted. They have the appearance that they have in background windows. Also, focus rings don't show up, and the caret is disabled.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/10235607>
Simon Fraser (smfr)
Actually form controls look OK, but just different in Lion. Focus rings are still missing though.
Simon Fraser (smfr)
DRT/WK1 have some smarts here that we may need to replicate:
in - (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame:
gLayoutTestController->setWindowIsKey(true);
NSView *documentView = [[mainFrame frameView] documentView];
[[[mainFrame webView] window] makeFirstResponder:documentView];
void LayoutTestController::setWindowIsKey(bool windowIsKey)
{
m_windowIsKey = windowIsKey;
[[mainFrame webView] _updateActiveState];
}
WebView:
- (void)_updateActiveState
{
if (_private && _private->page)
_private->page->focusController()->setActive([[self window] isKeyWindow]);
}
Simon Fraser (smfr)
*** This bug has been marked as a duplicate of bug 42688 ***