Bug 69352

Summary: Add run-time enabled flag for <track>
Product: WebKit Reporter: Anna Cavender <annacc>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, eric, gustavo.noronha, gustavo, scherkus, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Patch
none
gtk snafu fixed none

Anna Cavender
Reported 2011-10-04 10:42:12 PDT
Runtime-enabling <track> involves enabling/disabling entire interfaces/classes (e.g. HTMLTrackElement, TextTrack, TextTrackCue, etc.) not just individual class attributes. Therefore, this change will modify the CodeGenerator to accept the EnabledAtRuntime idl attribute for interfaces.
Attachments
Patch (7.59 KB, patch)
2011-10-04 11:05 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
gtk snafu fixed (7.51 KB, patch)
2011-10-04 17:33 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2011-10-04 11:05:17 PDT
Created attachment 109651 [details] Patch
Adam Barth
Comment 2 2011-10-04 11:34:48 PDT
Comment on attachment 109651 [details] Patch Looks great.
Eric Seidel (no email)
Comment 3 2011-10-04 11:35:28 PDT
Don't we test runtime features using layoutTestController additions? We certainly can test some preferences that way, but I'm not sure if there is precedent for testing v8 runtime features that way.
Adam Barth
Comment 4 2011-10-04 11:37:53 PDT
Presumably we'll get that test coverage when we test <track> itself.
Collabora GTK+ EWS bot
Comment 5 2011-10-04 16:55:21 PDT
Comment on attachment 109651 [details] Patch Attachment 109651 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9944567
Anna Cavender
Comment 6 2011-10-04 17:33:02 PDT
Created attachment 109722 [details] gtk snafu fixed
WebKit Review Bot
Comment 7 2011-10-05 11:07:39 PDT
Comment on attachment 109722 [details] gtk snafu fixed Clearing flags on attachment: 109722 Committed r96727: <http://trac.webkit.org/changeset/96727>
WebKit Review Bot
Comment 8 2011-10-05 11:07:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.