Summary: | Add run-time enabled flag for <track> | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anna Cavender <annacc> | ||||||
Component: | Media | Assignee: | Anna Cavender <annacc> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric.carlson, eric, gustavo.noronha, gustavo, scherkus, tony, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 43668 | ||||||||
Attachments: |
|
Description
Anna Cavender
2011-10-04 10:42:12 PDT
Created attachment 109651 [details]
Patch
Comment on attachment 109651 [details]
Patch
Looks great.
Don't we test runtime features using layoutTestController additions? We certainly can test some preferences that way, but I'm not sure if there is precedent for testing v8 runtime features that way. Presumably we'll get that test coverage when we test <track> itself. Comment on attachment 109651 [details] Patch Attachment 109651 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9944567 Created attachment 109722 [details]
gtk snafu fixed
Comment on attachment 109722 [details] gtk snafu fixed Clearing flags on attachment: 109722 Committed r96727: <http://trac.webkit.org/changeset/96727> All reviewed patches have been landed. Closing bug. |