Bug 69272

Summary: [WinCairo] Switch to Release builds and activate tests on buildbot
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 69280    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch rniwa: review+

Brent Fulgham
Reported 2011-10-03 11:27:39 PDT
Change the WinCairo build bot configuration to build the Release target, and start running tests.
Attachments
Patch (1.58 KB, patch)
2011-10-03 11:31 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.57 KB, patch)
2011-10-03 11:35 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2011-10-04 20:00 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2011-10-05 17:31 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2011-10-06 15:30 PDT, Brent Fulgham 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2011-10-03 11:31:15 PDT
Created attachment 109500 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-10-03 11:32:47 PDT
Comment on attachment 109500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109500&action=review Since we expect this to turn the bot red, perhaps we should also remove the bot from the set of core builders? > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:257 > + "name": "WinCairo Release (Build)", "type": "BuildAndTest", "builddir": "win-cairo-release", The "(Build)" suffix is typically only used for build-only bots. So I think you should remove it.
Brent Fulgham
Comment 3 2011-10-03 11:35:11 PDT
Created attachment 109501 [details] Patch
Brent Fulgham
Comment 4 2011-10-04 20:00:29 PDT
Created attachment 109734 [details] Patch
Brent Fulgham
Comment 5 2011-10-05 17:31:51 PDT
Created attachment 109889 [details] Patch
Brent Fulgham
Comment 6 2011-10-05 17:35:29 PDT
Landed in http://trac.webkit.org/changeset/96773.
Brent Fulgham
Comment 7 2011-10-06 15:28:10 PDT
Reopen to correct bug in config file: aroben: bfulgham-afk: AssertionError: <buildbot.schedulers.basic.AnyBranchScheduler instance at 0x102239a70> uses unknown builder WinCairo Debug (Build) [8:55pm] aroben: bfulgham-afk: I think your patch is buggy [8:55pm] rakuco: smfr: hey. do you have plans to commit the parts of your patch in bug 68134 which you didn't commit (namely the ScrollbarTheme::theme() part)? I've been running a slightly modified version of the code locally for EFL's DRT and it's been working fine [8:55pm] aroben: bfulgham-afk: looks like config.json still contains an instance of "WinCairo Debug (Build)"
Brent Fulgham
Comment 8 2011-10-06 15:30:08 PDT
Created attachment 110044 [details] Patch
Brent Fulgham
Comment 9 2011-10-06 15:42:45 PDT
Committed r96865: <http://trac.webkit.org/changeset/96865>
Note You need to log in before you can comment on or make changes to this bug.