Summary: | BiquadFilterNode .type attribute is not handled correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||
Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, jer.noble, kbr, smus | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Rogers
2011-09-30 16:14:14 PDT
Created attachment 109375 [details]
Patch
Comment on attachment 109375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review Looks fine overall; couple of comments. r=me > LayoutTests/webaudio/biquadfilternode-basic.html:29 > + // FIXME: we need to expose the actual filter type constants in the IDL Have you already filed a bug about this? > LayoutTests/webaudio/biquadfilternode-basic.html:38 > + for (var i = 0; i <= 7; ++i) { FIXME for the magic constant 7. > Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61 > + m_hasJustReset = true; Is this fix really related or should it be a separate change? Committed r96525: <http://trac.webkit.org/changeset/96525> Comment on attachment 109375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review >> LayoutTests/webaudio/biquadfilternode-basic.html:29 >> + // FIXME: we need to expose the actual filter type constants in the IDL > > Have you already filed a bug about this? Just filed: https://bugs.webkit.org/show_bug.cgi?id=69276 >> LayoutTests/webaudio/biquadfilternode-basic.html:38 >> + for (var i = 0; i <= 7; ++i) { > > FIXME for the magic constant 7. added FIXME here >> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61 >> + m_hasJustReset = true; > > Is this fix really related or should it be a separate change? It's related since, it's required when changing filter types. The filter state needs to be reset... Thanks for fixing. Verified in Canary. |