Bug 69182

Summary: BiquadFilterNode .type attribute is not handled correctly
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, kbr, smus
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Description Chris Rogers 2011-09-30 16:14:14 PDT 
BiquadFilterNode .type attribute is not handled correctly
Comment 1 Chris Rogers 2011-09-30 17:06:06 PDT 
Created attachment 109375 [details]
Patch
Comment 2 Kenneth Russell 2011-10-03 10:55:57 PDT 
Comment on attachment 109375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review

Looks fine overall; couple of comments. r=me

> LayoutTests/webaudio/biquadfilternode-basic.html:29
> +    // FIXME: we need to expose the actual filter type constants in the IDL

Have you already filed a bug about this?

> LayoutTests/webaudio/biquadfilternode-basic.html:38
> +    for (var i = 0; i <= 7; ++i) {

FIXME for the magic constant 7.

> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61
> +    m_hasJustReset = true;

Is this fix really related or should it be a separate change?
Comment 3 Chris Rogers 2011-10-03 12:12:26 PDT 
Committed r96525: <http://trac.webkit.org/changeset/96525>
Comment 4 Chris Rogers 2011-10-03 12:15:11 PDT 
Comment on attachment 109375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109375&action=review

>> LayoutTests/webaudio/biquadfilternode-basic.html:29
>> +    // FIXME: we need to expose the actual filter type constants in the IDL
> 
> Have you already filed a bug about this?

Just filed:
https://bugs.webkit.org/show_bug.cgi?id=69276

>> LayoutTests/webaudio/biquadfilternode-basic.html:38
>> +    for (var i = 0; i <= 7; ++i) {
> 
> FIXME for the magic constant 7.

added FIXME here

>> Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:61
>> +    m_hasJustReset = true;
> 
> Is this fix really related or should it be a separate change?

It's related since, it's required when changing filter types.  The filter state needs to be reset...
Comment 5 Boris Smus 2011-10-04 13:26:46 PDT 
Thanks for fixing. Verified in Canary.