Summary: | nrwt: newly generated results are put in cross-platform directory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, hyatt, leandro, ojan, rakuco, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 64491 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-09-27 13:48:03 PDT
Created attachment 111882 [details]
fixes the bug
Comment on attachment 111882 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=111882&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:145 > + _render_tree_dump_pattern = re.compile(r"^layer at \(\d+,\d+\) size \d+x\d+\n") hum... (In reply to comment #2) > (From update of attachment 111882 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111882&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:145 > > + _render_tree_dump_pattern = re.compile(r"^layer at \(\d+,\d+\) size \d+x\d+\n") > > hum... Don't like it? Looks like a hack, right? (In reply to comment #4) > Looks like a hack, right? Not really. I'm detecting whether the output looks like render tree dump or not. Since there is currently no way for us to know whether a test prints render tree dump or not, I don't think we can do better. orwt uses a similar trick in isTextOnlyTest. Another approach might be to have DRT return a Content-Type header that says whether it is a text dump or a render tree dump. (In reply to comment #6) > Another approach might be to have DRT return a Content-Type header that says whether it is a text dump or a render tree dump. Yeah, that'll be cleaner and will be a nice follow up to do. This bug is about the regression that nrwt doesn't behave like orwt and this patch fixes exactly that. Comment on attachment 111882 [details] fixes the bug Clearing flags on attachment: 111882 Committed r98062: <http://trac.webkit.org/changeset/98062> All reviewed patches have been landed. Closing bug. |