Bug 68738

Summary: Add a mechanism to test for the compositing tree mutated during painting
Product: WebKit Reporter: James Robinson <jamesr>
Component: Layout and RenderingAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, jamesr, simon.fraser, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
some assertions, no test case yet
none
Patch none

James Robinson
Reported 2011-09-23 15:17:19 PDT
We've had a lot of bugs in the past with compositing turning off or the GraphicsLayer tree being mutated during painting. See https://bugs.webkit.org/show_bug.cgi?id=54707, http://trac.webkit.org/changeset/45715/trunk/WebCore/rendering/RenderLayer.cpp and others. We should add ASSERT()s to catch this case and some test cases to hit the areas where we've seen this happen in the past.
Attachments
some assertions, no test case yet (2.20 KB, patch)
2011-09-23 15:41 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (4.75 KB, patch)
2011-09-23 18:25 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-09-23 15:41:47 PDT
Created attachment 108549 [details] some assertions, no test case yet
James Robinson
Comment 2 2011-09-23 15:46:01 PDT
I'm working on reduce a manual test case down to something automated that will make this ASSERT() hit without the fix in https://bugs.webkit.org/show_bug.cgi?id=68727.
James Robinson
Comment 3 2011-09-23 18:25:58 PDT
Created attachment 108572 [details] Patch
James Robinson
Comment 4 2011-09-23 18:26:33 PDT
Many bothans died to bring you this test case that reliably fails in DRT prior to http://trac.webkit.org/changeset/95863. The timing is unbelievably sensitive.
Adam Barth
Comment 5 2011-09-23 19:30:31 PDT
Comment on attachment 108572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108572&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:65 > +static bool s_inPaintContents = false; I would have used a counter, but that's because I'm paranoid about re-entrancy from working on the parser. :)
WebKit Review Bot
Comment 6 2011-09-27 14:46:35 PDT
Comment on attachment 108572 [details] Patch Clearing flags on attachment: 108572 Committed r96160: <http://trac.webkit.org/changeset/96160>
WebKit Review Bot
Comment 7 2011-09-27 14:46:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.