Bug 68599

Summary:

[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

68994

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
rebased	none
diff_for_easy_review	none
Patch	none

Ryuan Choi

Reported 2011-09-22 01:13:51 PDT

Patch will be added.

Attachments
Patch (214.04 KB, patch) 2011-09-27 17:28 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (214.04 KB, patch) 2011-09-27 17:35 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (214.04 KB, patch) 2011-09-28 04:03 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (214.04 KB, patch) 2011-09-28 04:09 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
rebased (213.84 KB, patch) 2011-09-28 20:42 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
diff_for_easy_review (33.88 KB, patch) 2011-09-28 21:00 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Patch (213.83 KB, patch) 2011-09-29 17:31 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Ryuan Choi

Comment 1 2011-09-27 17:28:12 PDT

Created attachment 108939 [details] Patch

Gyuyoung Kim

Comment 2 2011-09-27 17:33:02 PDT

Comment on attachment 108939 [details] Patch Attachment 108939 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9879510

Ryuan Choi

Comment 3 2011-09-27 17:35:59 PDT

Created attachment 108942 [details] Patch

Gyuyoung Kim

Comment 4 2011-09-27 17:40:04 PDT

Comment on attachment 108942 [details] Patch Attachment 108942 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9883420

Ryuan Choi

Comment 5 2011-09-27 17:55:06 PDT

(In reply to comment #4) > (From update of attachment 108942 [details]) > Attachment 108942 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/9883420 It's because of old eina. I'll bump eina at different bug. Gyuyoung, Could you update build bot?

Gyuyoung Kim

Comment 6 2011-09-28 01:12:12 PDT

(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 108942 [details] [details]) > > Attachment 108942 [details] [details] did not pass efl-ews (efl): > > Output: http://queues.webkit.org/results/9883420 > > It's because of old eina. > I'll bump eina at different bug. > > Gyuyoung, Could you update build bot? I update eina both ews and buildbot. Please submit your patch again.

Ryuan Choi

Comment 7 2011-09-28 04:03:37 PDT

Created attachment 108999 [details] Patch

Ryuan Choi

Comment 8 2011-09-28 04:09:41 PDT

Created attachment 109000 [details] Patch

Ryuan Choi

Comment 9 2011-09-28 20:42:29 PDT

Created attachment 109117 [details] rebased

Gyuyoung Kim

Comment 10 2011-09-28 20:46:38 PDT

I wonder which codes are changed to fix compile errors. Because, it is difficult to find the changes in this patch.

Ryuan Choi

Comment 11 2011-09-28 21:00:15 PDT

Created attachment 109119 [details] diff_for_easy_review Attached file is diff after renamed for easy review. It is same with 109117 without renaming.

Gyuyoung Kim

Comment 12 2011-09-29 16:54:21 PDT

Comment on attachment 109119 [details] diff_for_easy_review View in context: https://bugs.webkit.org/attachment.cgi?id=109119&action=review > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:834 > + void* newItems = realloc(priv->view.items, sizeof(Eina_Inlist*) * (int)rows); Missing to use C++ casting in (int)rows.

Ryuan Choi

Comment 13 2011-09-29 17:31:08 PDT

Created attachment 109225 [details] Patch

Ryuan Choi

Comment 14 2011-09-29 17:32:32 PDT

(In reply to comment #12) > (From update of attachment 109119 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109119&action=review > > > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:834 > > + void* newItems = realloc(priv->view.items, sizeof(Eina_Inlist*) * (int)rows); > > Missing to use C++ casting in (int)rows. I fixed it by removing (int). Other is same.

Hajime Morrita

Comment 15 2011-10-02 22:16:44 PDT

Comment on attachment 109225 [details] Patch Rubberstamping.

WebKit Review Bot

Comment 16 2011-10-03 07:12:28 PDT

Comment on attachment 109225 [details] Patch Clearing flags on attachment: 109225 Committed r96495: <http://trac.webkit.org/changeset/96495>

WebKit Review Bot

Comment 17 2011-10-03 07:12:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.