Bug 68576

Summary:

MiniBrowser fails to launch when double-clicked

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sfalken, webkit-bug-importer

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

68578

Bug Blocks:

Attachments:

Description	Flags
Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code	andersca: review+

Description Adam Roben (:aroben) 2011-09-21 15:25:31 PDT

To reproduce:

1. Double-click MiniBrowser.exe

It doesn't launch. It complains about not being able to find CFNetwork.dll.

Comment 1 Radar WebKit Bug Importer 2011-09-21 15:25:57 PDT

<rdar://problem/10163853>

Comment 2 Adam Roben (:aroben) 2011-09-21 15:36:14 PDT

It's possible we'll be able to fix this by delay-loading WebKit.dll and setting up the DLL search path before we make any WebKit API calls.

Comment 3 Adam Roben (:aroben) 2011-09-22 09:54:08 PDT

Looks like delay-loading isn't good enough. We're still loading WebKit.dll immediately on launch, which then pulls in CoreFoundation etc.

Comment 4 Adam Roben (:aroben) 2011-09-22 11:48:37 PDT

Since we're going to need a stub launcher for WinLauncher, too (bug 68578), maybe we'll come up with a way to share the launcher code. We might be able to share code with WebKitLauncherWin, too.

Comment 5 Adam Roben (:aroben) 2012-01-04 11:59:29 PST

Created attachment 121133 [details]
Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code

Comment 6 Adam Roben (:aroben) 2012-01-05 06:58:32 PST

Committed r104155: <http://trac.webkit.org/changeset/104155>