| Summary: | Changelog class should have a method to return all entries | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Leandro Pereira <leandro> | ||||||
| Component: | New Bugs | Assignee: | Leandro Pereira <leandro> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, rniwa, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 68115 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Leandro Pereira
2011-09-19 15:19:34 PDT
Created attachment 107929 [details]
Patch
CC'ing Ryosuke Niwa. Comment on attachment 107929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107929&action=review > Tools/ChangeLog:7 > + Implement ChangeLog.parse_entries_from_file(). This method returns a > + generator of ChangeLogEntry objects, ordered from the latest to the Can you put generator on the previous line? It seems odd to end a line with an article. > Tools/ChangeLog:15 > + * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test > + case. Seems like you can hit the entire thing in one line. > Tools/Scripts/webkitpy/common/checkout/changelog.py:171 > + # If we've hit the next entry, return. Nit: We don't return here, right? Comment on attachment 107929 [details]
Patch
Forgot to submit a new patch taking care of rniwa's comments.
Created attachment 108011 [details]
Patch
Comment on attachment 108011 [details] Patch Clearing flags on attachment: 108011 Committed r95549: <http://trac.webkit.org/changeset/95549> All reviewed patches have been landed. Closing bug. |