Bug 68292

Summary: Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68012    
Attachments:
Description Flags
Patch none

Description Adam Barth 2011-09-16 16:57:34 PDT 
Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
Comment 1 Adam Barth 2011-09-16 16:59:21 PDT 
Created attachment 107748 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-09-16 17:58:15 PDT 
Comment on attachment 107748 [details]
Patch

Why USE?  Isn't this a feature?
Comment 3 Eric Seidel (no email) 2011-09-16 17:58:58 PDT 
Comment on attachment 107748 [details]
Patch

Do we have other sanitizers we can use?  What happens when this is disabled?
Comment 4 Adam Barth 2011-09-16 18:18:14 PDT 
> Why USE?  Isn't this a feature?

Nope.  It's just a library:

http://code.google.com/p/ots/

> Do we have other sanitizers we can use?  What happens when this is disabled?

Folks who don't use the sanitizer just use the fonts directly, which increases security risk.
Comment 5 Adam Barth 2011-09-19 15:53:49 PDT 
Comment on attachment 107748 [details]
Patch

Clearing flags on attachment: 107748

Committed r95487: <http://trac.webkit.org/changeset/95487>
Comment 6 Adam Barth 2011-09-19 15:53:52 PDT 
All reviewed patches have been landed.  Closing bug.