Summary: | ChangeLogEntry class should contain a list of touched files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leandro Pereira <leandro> | ||||
Component: | Tools / Tests | Assignee: | Leandro Pereira <leandro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dbates, eric, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 68399 | ||||||
Attachments: |
|
Description
Leandro Pereira
2011-09-14 14:05:20 PDT
Created attachment 107390 [details]
Patch
Comment on attachment 107390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107390&action=review > Tools/ChangeLog:8 > + Add method to return the list of files touched in a ChangeLog entry. Nit: Add a method? > Tools/Scripts/webkitpy/common/checkout/changelog.py:78 > + # e.g. * Source/WebCore/page/EventHandler.cpp: Implement FooBarQuux. > + touched_files_regexp = r'\s*\*\s*(?P<file>.+)\:' Mn... files move every now and then so maybe we just want to partially match? e.g. WebCore -> Source/WebCore. Comment on attachment 107390 [details]
Patch
This seems reasonable.
Comment on attachment 107390 [details] Patch Clearing flags on attachment: 107390 Committed r95547: <http://trac.webkit.org/changeset/95547> All reviewed patches have been landed. Closing bug. |