Bug 68115

Summary: ChangeLogEntry class should contain a list of touched files
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: Tools / TestsAssignee: Leandro Pereira <leandro>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68399    
Attachments:
Description Flags
Patch none

Leandro Pereira
Reported 2011-09-14 14:05:20 PDT
ChangeLogEntry class should contain a list of touched files
Attachments
Patch (3.15 KB, patch)
2011-09-14 14:07 PDT, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2011-09-14 14:07:30 PDT
Created attachment 107390 [details] Patch
Ryosuke Niwa
Comment 2 2011-09-14 14:12:42 PDT
Comment on attachment 107390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107390&action=review > Tools/ChangeLog:8 > + Add method to return the list of files touched in a ChangeLog entry. Nit: Add a method? > Tools/Scripts/webkitpy/common/checkout/changelog.py:78 > + # e.g. * Source/WebCore/page/EventHandler.cpp: Implement FooBarQuux. > + touched_files_regexp = r'\s*\*\s*(?P<file>.+)\:' Mn... files move every now and then so maybe we just want to partially match? e.g. WebCore -> Source/WebCore.
Eric Seidel (no email)
Comment 3 2011-09-14 23:26:50 PDT
Comment on attachment 107390 [details] Patch This seems reasonable.
WebKit Review Bot
Comment 4 2011-09-20 09:30:22 PDT
Comment on attachment 107390 [details] Patch Clearing flags on attachment: 107390 Committed r95547: <http://trac.webkit.org/changeset/95547>
WebKit Review Bot
Comment 5 2011-09-20 09:30:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.