Bug 67907

Summary: Switch most calls in DFGJITCodeGenerator to use callOperation.
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-09-11 14:15:33 PDT
WTF has an idiom where C preprocessor macros that indicate whether or not a feature is enabled begin with the ENABLE_ prefix, and are queried using the ENABLE() macro. DFGNode.h does not use this idiom, even though it should.
Attachments
the patch (17.91 KB, patch)
2011-09-11 14:44 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-09-11 14:44:24 PDT
Created attachment 107009 [details] the patch
Filip Pizlo
Comment 2 2011-09-11 15:46:21 PDT
Comment on attachment 107009 [details] the patch Tests pass, landing.
WebKit Review Bot
Comment 3 2011-09-11 20:41:47 PDT
Comment on attachment 107009 [details] the patch Clearing flags on attachment: 107009 Committed r94942: <http://trac.webkit.org/changeset/94942>
WebKit Review Bot
Comment 4 2011-09-11 20:41:51 PDT
All reviewed patches have been landed. Closing bug.
Gavin Barraclough
Comment 5 2011-10-13 14:49:26 PDT
This change was invalid, this will be fixed by https://bugs.webkit.org/show_bug.cgi?id=70060
Note You need to log in before you can comment on or make changes to this bug.