Summary: | Chromium shadow-buffer-partial test change. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | bungeman | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kbr, webkit.review.bot | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
bungeman
2011-09-09 08:21:52 PDT
Created attachment 106874 [details]
Patch
Adding reviewer. Note that this is an extension to Bug 67724, since Bug 67596 managed to make the blur change affect more tests. Comment on attachment 106874 [details]
Patch
Unless the tests are crashing we should not skip running them, because then we won't see any really bad code changes that might make them actually crash. Just mark the expectations PASS FAIL.
Created attachment 107046 [details]
Patch
Comment on attachment 107046 [details]
Patch
Have changed tests from SKIP to just PASS FAIL.
Comment on attachment 107046 [details]
Patch
Looks fine. r=me
Comment on attachment 107046 [details] Patch Clearing flags on attachment: 107046 Committed r94963: <http://trac.webkit.org/changeset/94963> All reviewed patches have been landed. Closing bug. |