Bug 67849

Summary:

Chromium shadow-buffer-partial test change.

Product:

WebKit

Reporter:

bungeman

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kbr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

bungeman

Reported 2011-09-09 08:21:52 PDT

A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/ inset-box-shadow-radius and inset-box-shadows need to be updated, as they currently have an incorrect blur. This change will be to set these tests to be skipped. Once chromium rolls to skip the tests, the fix there (currently disabled) will be enabled. Then, after webkit rolls chromium past this change, there will be another webkit change to re-enable the tests. This is an extension to Bug 67724 as Bug 67596 (which went in yesterday right after Bug 67724 went in) re-enabled these two tests in test expectations.

Attachments
Patch (1.28 KB, patch) 2011-09-09 08:29 PDT, bungeman	no flags	Details Formatted Diff Diff
Patch (1.34 KB, patch) 2011-09-12 06:28 PDT, bungeman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

bungeman

Comment 1 2011-09-09 08:29:58 PDT

Created attachment 106874 [details] Patch

bungeman

Comment 2 2011-09-09 08:32:54 PDT

Adding reviewer. Note that this is an extension to Bug 67724, since Bug 67596 managed to make the blur change affect more tests.

Kenneth Russell

Comment 3 2011-09-09 14:54:59 PDT

Comment on attachment 106874 [details] Patch Unless the tests are crashing we should not skip running them, because then we won't see any really bad code changes that might make them actually crash. Just mark the expectations PASS FAIL.

bungeman

Comment 4 2011-09-12 06:28:22 PDT

Created attachment 107046 [details] Patch

bungeman

Comment 5 2011-09-12 06:29:43 PDT

Comment on attachment 107046 [details] Patch Have changed tests from SKIP to just PASS FAIL.

Kenneth Russell

Comment 6 2011-09-12 09:43:49 PDT

Comment on attachment 107046 [details] Patch Looks fine. r=me

WebKit Review Bot

Comment 7 2011-09-12 10:44:33 PDT

Comment on attachment 107046 [details] Patch Clearing flags on attachment: 107046 Committed r94963: <http://trac.webkit.org/changeset/94963>

WebKit Review Bot

Comment 8 2011-09-12 10:44:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.